feat(color): add seed variables for palette colors#573
Open
didimmova wants to merge 2 commits into
Open
Conversation
didimmova
added
❌ status: awaiting-test
simeonoff
requested changes
May 20, 2026
| ) { | ||
| $color-shades: types.$IColorShades; | ||
| $gray-shades: types.$IGrayShades; | ||
| $gray: if($gray, $gray, if(luminance($surface) > 0.5, #000, #fff)); |
Contributor
There was a problem hiding this comment.
This is weird, it's already handled by the shade function. There's a special clause that already extracts the luminance of the surface color in regards to the gray shade. Honestly, I don't think that extra step is needed. Instead of doing it the way you're doing it now, it's my strong conviction that you can add a "seed" value to the Color Types ($IGrayShades, and $IColorShades), and have a modifier of 1 for the static multiplier maps for for both the gray seed and the color seed variants. The shade function will just produce another color "shade" - seed then. The shades function stays the same as it is today (bar the bug fix you introduced for the error color).
Does that make sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #520