fix(list): focus styles#15718
Merged
Merged
Conversation
SisIvanova
added
list
❌ status: awaiting-test
simeonoff
reviewed
Apr 14, 2025
| align-items: center; | ||
| position: relative; | ||
| border-radius: var-get($theme, 'item-border-radius'); | ||
| background: inherit; |
Collaborator
There was a problem hiding this comment.
@SisIvanova I have a feeling that this is important especially when panning items. Take a look at the scoped styles PR and how the sample has been updated there to support panning so this can be tested before merging.
Collaborator
Author
There was a problem hiding this comment.
My point was to fix the background being applied to both the wrapper and the nested component, which causes a bug in indigo theme where the background has some opacity. This was already fixed by you in the scoped-styles branch. I updated the sample with the panning option so that you and @didimmova can easily test if everything looks good.
simeonoff
approved these changes
Apr 14, 2025
simeonoff
added
✅ status: verified
didimmova
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15664
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)