Introduce Callout#358
Conversation
|
I like the design, especially the color matching border. The spacing of text and headline are well done. We should check, though, if there are elements, that have the same or a similar purpose and make sure that the design is consistent. Please make also sure, that the in this case the line breaks after max. 80 characters to ensure readability. @TheSyscall Would be nice, if you could post a screenshot of the element positioned on top of the page. |
|
On the top of a configuration form without any limit. (limited only by the content) Limited to 80ch/50em. Setting the limit like that breaks the use over form elements. |
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Tested together with Icinga/icingaweb2#5477 (review).
|
Would love to see this feature soon, so I don't have to create an own callout widget for Icinga/icingaweb2#5430. |
Implement a callout box element that can be used to convey important information to the user. This element is designed to be used above certain form elements, or over the whole form or page.
Co-authored-by: jrauh01 <id4jojo@gmail.com>
jrauh01
left a comment
jrauh01
left a comment
There was a problem hiding this comment.
Just some minor phpdocs adjustments.
Co-authored-by: jrauh01 <id4jojo@gmail.com>
Change setFullwidth to setFullWidth Co-authored-by: jrauh01 <johannes.rauh@icinga.com>
Co-authored-by: jrauh01 <johannes.rauh@icinga.com>
jrauh01
left a comment
jrauh01
left a comment
There was a problem hiding this comment.
Consider adding unit tests. Otherwise this looks good now.
This allows for a title with a string that evaluates to a falsy value
Co-authored-by: jrauh01 <johannes.rauh@icinga.com>
5 participants
Implement a callout box element that can be used to convey important information to the user.
This element is designed to be used above certain form elements, over the whole form or page.
It seems like the use of callout could conflict with the existing
FormDescriptionandFormNotificationdecorators, at least within IW2 forms.Callouts are not meant as a direct replacement for these decorators but as a more universal ipl widget that can be used even outside of forms to convey essential information to the user.
Merging these two concepts by extending the form-notification would be a viable alternative to this PR.
Callout types:
Callout full width:
Callout with optional title:
Callout above a form element:
closes #349