Skip to content

Revert adding PerfdataWriterConnection#10851

Merged
jschmidt-icinga merged 2 commits into
support/2.16from
revert-perfdatawriterconnection
May 21, 2026
Merged

Revert adding PerfdataWriterConnection#10851
jschmidt-icinga merged 2 commits into
support/2.16from
revert-perfdatawriterconnection

Conversation

@jschmidt-icinga
Copy link
Copy Markdown
Contributor

@jschmidt-icinga jschmidt-icinga commented May 20, 2026

We still can't reproduce #10825 on our end or get any reliable info on what is causing the problem, so this reverts the merges of #10799 and #10668 on the 2.16 branch.

We are aware of #10848 and the locking issue discovered there, but for now concluded that rolling out a fix for that is too uncertain, without knowing the underlying issue of why the perfdata writer queues stop.

refs #10842 (this PR fixes it for support/2.16, issue remains open for master branch)
refs #10848 (this PR fixes it for support/2.16, issue remains open for master branch)
refs #10825 (this PR fixes it for support/2.16, issue remains open for master branch)

@cla-bot cla-bot Bot added the cla/signed label May 20, 2026
@jschmidt-icinga jschmidt-icinga force-pushed the revert-perfdatawriterconnection branch from bb821da to 103779d Compare May 20, 2026 10:47
@julianbrost
Copy link
Copy Markdown
Member

I've checked using git diff v2.15.3..revert-perfdatawriterconnection lib/perfdata/ that this PR reverts the perfdata writers to the state as of v2.15.3 with the following exception (at commit 103779d):

  1. OTLPMetricsWriter is still there (which is unrelated to the writers causing problems).
  2. Deprecation warning for ElasticsearchWriter is still there.
  3. Minor changes to remove compiler warnings (making casts explicit, removing unused function parameters).
  4. Changes of the file headers to use SPDX syntax.

@julianbrost julianbrost added this to the 2.16.1 milestone May 20, 2026
julianbrost
julianbrost previously approved these changes May 20, 2026
@jschmidt-icinga
Copy link
Copy Markdown
Contributor Author

with the following exception

The only real exception I made outside of solving those conflicts was also keeping the using namespace std::chrono_literals; in i2_base.hpp, since there were a few classes now requiring it. But that shouldn't really affect anything.

…tion-handling"

This reverts commit 6592eae, reversing
changes made to 41109e2.
@jschmidt-icinga jschmidt-icinga force-pushed the revert-perfdatawriterconnection branch from cef29ed to 9110c45 Compare May 20, 2026 15:36
@jschmidt-icinga
Copy link
Copy Markdown
Contributor Author

  • Removed the disconnect_timeout attribute from the revert so user's that might have set these attribute will not get errors after the upgrade. The attributes will silently be ignored.

@jschmidt-icinga jschmidt-icinga merged commit 910c0a7 into support/2.16 May 21, 2026
30 checks passed
@jschmidt-icinga jschmidt-icinga deleted the revert-perfdatawriterconnection branch May 21, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants