Hook implementation for event object display names#165
Merged
Conversation
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
from
ced4902 to
0fe4280
Compare
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
5 times, most recently
from
39e364e to
6081322
Compare
raviks789
changed the title
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
2 times, most recently
from
4ea63c1 to
26f9a45
Compare
Member
|
Please rebase, fix conflicts and mark as ready for review. |
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
from
26f9a45 to
d9da5ee
Compare
raviks789
changed the base branch from
main
to
fix/inefficient-list-views-which-render-object-names-153
raviks789
changed the base branch from
fix/inefficient-list-views-which-render-object-names-153
to
main
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
8 times, most recently
from
a41ed3d to
70fc00e
Compare
Contributor
|
Please rebase and resolve the conflicts. |
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
from
70fc00e to
59dd1e6
Compare
sukhwinder33445
requested changes
May 17, 2024
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
7 times, most recently
from
5a93238 to
9237ed0
Compare
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Please squash the commits.
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
from
9237ed0 to
4c14858
Compare
nilmerg
requested changes
May 28, 2024
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
4 times, most recently
from
0824684 to
20d556e
Compare
nilmerg
requested changes
May 28, 2024
raviks789
force-pushed
the
feature/event-object-hook-implementation
branch
from
20d556e to
cdeb542
Compare
nilmerg
previously approved these changes
May 29, 2024
nilmerg
requested changes
May 31, 2024
Because even if the hook(source) implementation is present, it is possible that the it cannot find a result for the given object (object is deleted/changed).
nilmerg
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #132
Blocked by: #155, #166
requires: Icinga/ipl-web#217