Feature/add probes#11
Draft
Donien wants to merge 8 commits into
Draft
Conversation
mocdaniel
approved these changes
Jun 1, 2023
Collaborator
There was a problem hiding this comment.
LGTM, let's get an additional review by @martialblog
Regarding IcingaDB and Director:
For the director we could look for the socket that should get created in the container's filesystem. I can't come up with the path to it right now, though.
For IcingaDB, no plausible healthcheck comes to mind, unfortunately. Maybe check for existence of a sub-process running the daemon? This could prevent false negatives as we currently see when using icinga/icingadb on ARM, at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially fixes #3.
It adds probes for
Those probes are an initial idea of what could be done. Also, the director and icingadb are not checked yet.