feat: implement Custom Docker Labels parsing and backend population (Fixes #1518)#213
Open
brianewman wants to merge 1 commit intoIceWhaleTech:mainfrom
Open
feat: implement Custom Docker Labels parsing and backend population (Fixes #1518)#213brianewman wants to merge 1 commit intoIceWhaleTech:mainfrom
brianewman wants to merge 1 commit intoIceWhaleTech:mainfrom
Conversation
Author
|
Closing this temporarily. I realized I targeted main instead of the correct development branch. I will open an issue to discuss the feature and find out the correct target branch before resubmitting. Thanks! |
Author
|
Upon further review, it appears it may be acceptable to submit this against main. I'm going to reopen it, but feel free to close it if I'm wrong. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds backend API support and container deployment logic for parsing arbitrary custom Docker Labels, allowing users to apply specific labels to their CasaOS applications.
This backend submission is the server-side companion to the label configuration wizard implemented in
CasaOS-UIPR 259.Changes Made
model/manifest.goto accept a newCustomLabels EnvArrayfield.v1schema to document the newcustom_labelsproperty.ToMap()mapper utility forEnvArrayinsidemodel/manifest_adapter.goto seamlessly morph the Key-Value array into themap[string]stringformat expected by Docker.dockerService.CreateContainer()in service/container.go to iterate over incoming custom labels and inject them directly into the deployment config, bringing parity to both legacy Docker installs and v2 Compose architectures.Related Issues