Test hardened ITensorActions workflows#173
Merged
Merged
Conversation
6163511 to
2e5d801
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 78.68% 78.68%
=======================================
Files 12 12
Lines 793 793
=======================================
Hits 624 624
Misses 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2e5d801 to
5c10fcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a workflow canary for the hardened reusable workflows in ITensorActions PR #88.
It updates the SparseArraysBase workflow callers to point at the ITensorActions PR head SHA so we can validate the new behavior before doing a broader ecosystem sweep:
IntegrationTest.ymlfrompull_request_targettopull_requestIntegrationTestpkgsJSON-array input, keeping one package per line for readable YAML diffsFormatCheck.ymlfrompull_request_targettopull_requestFormatCheckComment.ymlfor the trusted comment-writing step/integrationtestat the same ITensorActions test SHA and grant the check-writing permissions it needsCanary Note
FormatCheck.ymlsetsconcurrent-jobs: trueonly for this canary. The old default-branchpull_request_targetFormat Check still exists while this PR is open, and otherwise cancels the newpull_requestrun through the shared concurrency group. This line is not necessarily part of the eventual ecosystem sweep.Validation Goal
This PR should validate the public-package IntegrationTest matrix and the read-only FormatCheck parse phase on a normal same-repo PR. The
workflow_run-based comment workflow is included here, but full comment-writing validation may require a follow-up PR after this workflow exists on the default branch.Test Plan
IntegrationTestcheck passes for the public downstream matrix.Format Check / Check Formattingruns frompull_requestwithout trusted write permissions.