Tests.yml: trivially-pass non-canonical check-compat-bounds cells#68
Closed
Tests.yml: trivially-pass non-canonical check-compat-bounds cells#68
Conversation
Non-canonical reusable-workflow invocations (not ubuntu-latest + julia=1) previously produced gray "skipped" `Check compat bounds` checks because the gate was at the job level. Move the gate to every step inside the job so non-canonical invocations run a single echo and exit green. Adds ~15-30s of runner provisioning per non-canonical cell, but keeps the check UI clean and the real work running exactly once.
Member
Author
|
Superseded by a new approach: extracting the compat-bounds check into its own reusable workflow (CheckCompatBounds.yml), with a per-repo caller workflow to be rolled out via ITensorOrgPatches. Keeps a single clean status without matrix multiplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #67. Avoid gray "skipped"
Check compat boundsstatus checks on non-canonical matrix cells (observed on ITensor/DataGraphs.jl#94).Before:
if:gated the entirecheck-compat-boundsjob on(ubuntu-latest, julia=1).skipped(gray).After:
if:only gates on the globalcheck-compat-boundsinput + draft status — the job always materializes.echostep and exit success → all 6 check-compat statuses are green, only one does real work.Trade-off
Each non-canonical invocation still provisions a runner (~15-30s) just to echo a line. That's a little wasteful vs. truly skipping the job, but I think it's worth it for the cleaner status view. If the runner overhead becomes a concern later, we can go back to job-level gating.
Test plan
pre-commit run --all-filespasses.Check compat boundschecks are green rather than 1 green + 5 gray.🤖 Generated with Claude Code