Skip to content

IntegrationTest: skip aggregate gate on draft PRs #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 1 commit into from
May 7, 2026
Merged

IntegrationTest: skip aggregate gate on draft PRs #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/IntegrationTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,10 @@ jobs:
# that branch protection can require. Behavior:
# - matrix succeeded -> pass
# - `pkgs: '[]'` -> pass (no downstream configured)
# - draft + run-on-draft=false -> skip (matches the matrix-leg's draft
# skip; gate appears as Skipped on the PR
# rather than Failure for the expected
# no-signal case)
# - matrix all-skipped + fork -> fail with /integrationtest hint
# - any failure -> fail
# The fork-PR-all-skipped case is the trigger for the manual
Expand All @@ -229,7 +233,7 @@ jobs:
gate:
name: "IntegrationTest"
needs: integration-test
if: ${{ always() }}
if: ${{ always() && (!github.event.pull_request.draft || inputs.run-on-draft) }}
runs-on: ubuntu-latest
permissions:
actions: read
Expand Down
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,9 +567,11 @@ success, satisfying the gate.

### Draft PR behavior

By default, integration tests are skipped entirely for draft PRs. This is
controlled by the `run-on-draft` input (default: `false`). To run integration
tests even on draft PRs, set it to `true`:
By default, integration tests are skipped entirely for draft PRs. The matrix
legs and the aggregate `IntegrationTest` gate both report as Skipped (not
Failure) — the no-signal case on a draft is treated as expected, not a fault.
This is controlled by the `run-on-draft` input (default: `false`). To run
integration tests even on draft PRs, set it to `true`:

```yaml
uses: "ITensor/ITensorActions/.github/workflows/IntegrationTest.yml@v2"
Expand Down
Loading