Skip to content

Stamp commit sha in outputs#57

Merged
alasdairwilson merged 5 commits intomainfrom
stamp-commit-sha-in-outputs
Mar 25, 2026
Merged

Stamp commit sha in outputs#57
alasdairwilson merged 5 commits intomainfrom
stamp-commit-sha-in-outputs

Conversation

@alasdairwilson
Copy link
Copy Markdown
Member

Had to hack this a bit,

I have had this exact same issue before on other projects: the .git file is not in the docker container by design which means we can't resolve the SHA.

So we have to pass through in terms of env var when using docker but can use git itself via subprocess when being rean via python -m

closes #44

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
vertex/io.py 78.26% 5 Missing ⚠️
Files with missing lines Coverage Δ
vertex/IsaricDraw.py 12.54% <100.00%> (+0.17%) ⬆️
vertex/io.py 71.00% <78.26%> (+0.39%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@sr-murthy sr-murthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alasdairwilson Approved, with a couple of comments.

Comment thread vertex/io.py
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@alasdairwilson alasdairwilson merged commit 7849cb8 into main Mar 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically add VERTEX commit SHA to project config files

2 participants