Arc schema#3
Merged
pipliggins merged 37 commits intoISARICResearch:mainfrom Mar 23, 2026
Merged
Conversation
pipliggins
force-pushed
the
arc_schema
branch
from
cd67323 to
bf4b11f
Compare
… the current ARC variables
Instead of a list of different input types
pipliggins
force-pushed
the
arc_schema
branch
from
8aa42b9 to
afef71b
Compare
tedinburgh
previously requested changes
Mar 3, 2026
Contributor
tedinburgh
left a comment
tedinburgh
left a comment
There was a problem hiding this comment.
This looks great, thanks @pipliggins
I had a couple of comments on the draft parser script. The only other thing I wanted to check was that I assume the fields marked "TODO: FILL THIS IN" is to be handled downstream, is that correct?
abhidg
reviewed
Mar 8, 2026
Collaborator
abhidg
left a comment
abhidg
left a comment
There was a problem hiding this comment.
Looks good, couple of minor changes; and I'd add some tests.
Use unit utils to get accurate unit names, stop parser adding options for var + var_units as well as the unit-specific variables.
…nse options in parser
abhidg
approved these changes
Mar 18, 2026
Collaborator
abhidg
left a comment
abhidg
left a comment
There was a problem hiding this comment.
Looks good! There are a number of places with the missing valueset, they could be in one defined constant, can be done later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workflow which will run on tag to generate an ISARIC-standard long schema and ADTL parser file filled with the current ARC variables.