Skip to content

Add IMAP_HRC frame to SpiceFrame enum and update science frames kernel to v1.2.0#2808

Open
Copilot wants to merge 5 commits intodevfrom
copilot/add-imap-hrc-frame-to-spiceframe
Open

Add IMAP_HRC frame to SpiceFrame enum and update science frames kernel to v1.2.0#2808
Copilot wants to merge 5 commits intodevfrom
copilot/add-imap-hrc-frame-to-spiceframe

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

  • Create imap_science_120.tf in tests/spice/test_data/ (copy of imap_science_100.tf with IMAP_HRC frame at ID -43930 added)
  • Remove old imap_science_100.tf from tests/spice/test_data/
  • Copy imap_science_120.tf to ultra/l1c/sim_spice_kernels/
  • Update spice/geometry.py to add IMAP_HRC = -43930 to the SpiceFrame enum
  • Replace all references to imap_science_100.tf with imap_science_120.tf in all Python files
  • Verify test coverage - existing test_spice_frame_enum iterates over all SpiceFrame members and now covers IMAP_HRC
  • All affected tests pass
Original prompt

This section details on the original issue you should resolve

<issue_title>SPICE - Add IMAP_HRC frame to SpiceFrame</issue_title>
<issue_description>### Algorithm Description:

Nick has added the frame to the imap science frames kernel. This ticket is for adding that frame to the SpiceFrame enum.

  1. Add the new imap_science_120.tf to the repo in the tests/spice/test_data directory, replacing imap_science_100.tf
  2. Replace all references to imap_science_100.tf with the new imap_science_120.tf
  3. Add the new IMAP_HRC frame defined in the new imap science frame kernel to the SpiceFrame enum in spice/geometry.py
  4. Check test coverage of the SpiceFrame. There may be tests that iterate over SpiceFrame members that provide needed test coverage. If not, add test coverage exercising some geometry calculation using the new IMAP_HRC frame.
    </issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits March 3, 2026 22:20
Co-authored-by: subagonsouth <16110870+subagonsouth@users.noreply.github.com>
Co-authored-by: subagonsouth <16110870+subagonsouth@users.noreply.github.com>
Copilot AI changed the title [WIP] Add IMAP_HRC frame to SpiceFrame enum Add IMAP_HRC frame to SpiceFrame enum and update science frames kernel to v1.2.0 Mar 3, 2026
@subagonsouth
Copy link
Contributor

@copilot, please remove the old science frames kernel: imap_science_100.tf from the spice test_data directory.

Copilot AI and others added 2 commits March 4, 2026 15:49
…/test_data/

Co-authored-by: subagonsouth <16110870+subagonsouth@users.noreply.github.com>
Co-authored-by: subagonsouth <16110870+subagonsouth@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot, please remove the old science frames kernel: imap_science_100.tf from the spice test_data directory.

Done — removed imap_science_100.tf and added imap_science_120.tf to tests/spice/test_data/ in commits b068493 and 5a17e8c. (The file required force-adding since test_data/ is in .gitignore.)

Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subagonsouth subagonsouth marked this pull request as ready for review March 4, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SPICE - Add IMAP_HRC frame to SpiceFrame

2 participants