Skip to content

ULTRA l1b updates to spin and energy culling bins#2789

Merged
lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21:ultra_l1b_update_energy_and_spin_bins
Mar 3, 2026
Merged

ULTRA l1b updates to spin and energy culling bins#2789
lacoak21 merged 11 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21:ultra_l1b_update_energy_and_spin_bins

Conversation

@lacoak21
Copy link
Contributor

@lacoak21 lacoak21 commented Mar 2, 2026

Change Summary

Overview

Bob made some updates to the spin and energy bins that are used to cull spins at l1b. This includes combining spin bins into coarser bins for the high energy cull and updates to the number and size of the energy bins.

File changes

Testing

Created new data for the high energy validation test using Bobs updated code.

@lacoak21 lacoak21 added this to the March 2026 milestone Mar 2, 2026
@lacoak21 lacoak21 self-assigned this Mar 2, 2026
@lacoak21 lacoak21 added this to IMAP Mar 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ULTRA L1B culling configuration and logic to use revised energy-bin grouping and to smooth/aggregate spin-bin counts for high-energy culling, with corresponding constant and test updates.

Changes:

  • Update energy-bin grouping for culling (new base bin, fewer culling thresholds, and optional “merge-above-energy” behavior).
  • Modify high-energy culling to optionally combine multiple spin bins when computing counts.
  • Refresh unit/external-validation tests to reflect the updated binning/threshold expectations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File Description
imap_processing/ultra/l1b/ultra_l1b_culling.py Adds optional spin-bin combining for high-energy culling and adds max_energy handling to energy-range binning.
imap_processing/ultra/constants.py Updates culling constants: base energy bin, max-energy threshold, earth angle threshold, cull thresholds, and combined spin-bin size.
imap_processing/tests/ultra/unit/test_ultra_l1b_culling.py Updates tests and expected outputs for revised energy ranges/threshold counts and adds a test for binned energy ranges.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@laspsandoval laspsandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I caught. Nicely done Luisa!

@tech3371 tech3371 moved this to In Progress in IMAP Mar 2, 2026
@tech3371 tech3371 moved this from In Progress to PR Open in IMAP Mar 2, 2026
@lacoak21 lacoak21 merged commit 8b0328c into IMAP-Science-Operations-Center:dev Mar 3, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from PR Open to Done in IMAP Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants