Glows - final flags#2787
Conversation
|
@maxinelasp does this close this ticket too? #2688 Or is there more to do? |
maxinelasp
left a comment
There was a problem hiding this comment.
Looks great! This does complete #2721 , but does not complete #2688 (You can see that self.flags is still set to np.ones - filling in this variable is what #2688 covers).
Have you checked this by running the GLOWS CLI? There might be some changes required in glows_l1b.py. If that was validated, I am happy to approve.
Just tested an it produces the data products: |
94f7d72
into
IMAP-Science-Operations-Center:dev
This pull request enhances the GLOWS L1b data processing by implementing new per-bin quality flags for instrument team exclusions and suspected transients, improves the flagging logic, and updates tests and supporting data structures accordingly. The changes make the flagging system more robust and allow for more granular data quality tracking.
Enhancements to flagging logic and data structures:
IS_EXCLUDED_BY_INSTR_TEAMandIS_SUSPECTED_TRANSIENTto theGLOWSL1bFlagsenum inimap_processing/quality_flags.py, enabling more detailed quality tracking.flag_from_mask_datasetmethod inGLOWSL1bDatato retrieve per-bin boolean masks from xarray datasets, supporting the new exclusion and transient flags._compute_histogram_flag_arrayto populate the new flags using the mask datasets, and removed outdated TODOs now that the logic is implemented. [1] [2]Test and fixture improvements:
mock_ancillary_exclusionsfixture to provide realisticl1b_unique_block_identifierandhistogram_mask_arrayvalues for both instrument team exclusions and suspected transients, enabling more accurate testing. [1] [2]test_glows_l1b.pyto verify the correct operation offlag_from_mask_dataset, including shape and count checks for the exclusion mask.Minor code organization:
unique_block_identifierin__post_init__for clarity and to ensure correct initialization order.