Codice l2 hi sectored dim reversal#2778
Closed
lacoak21 wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
Closed
Codice l2 hi sectored dim reversal#2778lacoak21 wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
lacoak21
commented
Feb 26, 2026
| @@ -1078,7 +1078,9 @@ def process_hi_sectored(dependencies: ProcessingInputCollection) -> xr.Dataset: | |||
| spin_angle = (L2_HI_SECTORED_ANGLE[:, np.newaxis] + elevation_angles) % 360.0 | |||
Contributor
Author
There was a problem hiding this comment.
@tech3371 Im honestly still pretty confused about this. From my understanding:
This (L2_HI_SECTORED_ANGLE[np.newaxis, :] + elevation_angles) % 360.0 already creates an array that is spin_sector by elevation angle. Unless the variable names are mismatched? I have no understanding of l2 hi sectored code so I was wondering if this change made sense to you? Michael confirmed that the transpose was needed.
Contributor
There was a problem hiding this comment.
I will look into the details. It's been a while for me and I can look into where we should update.
Contributor
|
going to close this one and open new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Michael realized that the CoDICE hi l2 sectored data had the spin_angle array transposed. The dimensions were elevation_angle by spin sector but they should have been reversed. This PR fixes them.
File changes
imap_processing/codice/codice_l2.py
Transpose array