Skip to content

Update for amici>=1.0#663

Merged
arrjon merged 2 commits intodevelopfrom
amici100
Mar 25, 2026
Merged

Update for amici>=1.0#663
arrjon merged 2 commits intodevelopfrom
amici100

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Mar 23, 2026

Adapt to API changes. Update URLs.

Closes #661.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.95%. Comparing base (4b0e60a) to head (3e9705b).

Files with missing lines Patch % Lines
pyabc/petab/amici.py 75.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #663      +/-   ##
===========================================
+ Coverage    79.92%   79.95%   +0.02%     
===========================================
  Files          141      141              
  Lines         8325     8327       +2     
  Branches      1110     1110              
===========================================
+ Hits          6654     6658       +4     
+ Misses        1299     1298       -1     
+ Partials       372      371       -1     
Flag Coverage Δ
base 59.39% <0.00%> (-0.02%) ⬇️
external-R 36.67% <0.00%> (-0.01%) ⬇️
external-other-simulators 35.43% <0.00%> (-0.01%) ⬇️
migrate 25.35% <0.00%> (-0.01%) ⬇️
petab 35.49% <75.00%> (+0.07%) ⬆️
visualization 52.77% <0.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the amici100 branch 2 times, most recently from 07ebfbc to 26ad6de Compare March 23, 2026 14:36
Adapt to API changes. Update URLs.

Closes #661.
@dweindl dweindl marked this pull request as ready for review March 23, 2026 15:14
@arrjon arrjon self-requested a review March 25, 2026 10:32
Copy link
Copy Markdown
Member

@arrjon arrjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dweindl!

@arrjon arrjon merged commit 8ed2e00 into develop Mar 25, 2026
15 checks passed
@dweindl dweindl deleted the amici100 branch March 25, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants