This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Fix Rules.mk blanking out dependencies, fix incorrect actions.json usage#131
Merged
worksofliam merged 6 commits intomainfrom Jun 26, 2025
Merged
Fix Rules.mk blanking out dependencies, fix incorrect actions.json usage#131worksofliam merged 6 commits intomainfrom
Rules.mk blanking out dependencies, fix incorrect actions.json usage#131worksofliam merged 6 commits intomainfrom
Conversation
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
Rules.mk blanking out dependenciesRules.mk blanking out dependencies, fix incorrect actions.json usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SanjulaGanepola found a bug in ibmi-company_system where the makefile targets were missing
POPEMPandPOPDEPTcausing an error in the build:I confirmed that:
This was due to some logic in how we interpret the
Rules.mkfiles when building the makefile. We were letting those rules override the dependencies that were found by SO. Here is how the rules were setup for those objects:Additionally, a bug has been fixed where the incorrect command was being generated in the
makefile. This was due to a new feature that was added for 'steps' (not yet out) and was being included as part of the makefile by default. This caused incorrect commands to be used whenactions.jsonexisted, causing a break in existing builds.This fix, instead of removing the existing rules, combines them with the rules defined in
Rules.mk. Also, fixes a small bug with adding dependencies from SQL sources.