-
Notifications
You must be signed in to change notification settings - Fork 0
Add dark mode toggle functionality #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devloai
wants to merge
2
commits into
main
Choose a base branch
from
feature/add-dark-mode-1239
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import pytest | ||
| from src.searchapp.web.dash_app import toggle_theme | ||
|
|
||
| def test_toggle_theme_initial(): | ||
| """Test initial theme state""" | ||
| result = toggle_theme(None, None) | ||
| assert result == {"theme": "light"}, "Initial theme should be light" | ||
|
|
||
| def test_toggle_theme_to_dark(): | ||
| """Test toggling from light to dark theme""" | ||
| result = toggle_theme(1, {"theme": "light"}) | ||
| assert result == {"theme": "dark"}, "Theme should switch to dark" | ||
|
|
||
| def test_toggle_theme_to_light(): | ||
| """Test toggling from dark to light theme""" | ||
| result = toggle_theme(1, {"theme": "dark"}) | ||
| assert result == {"theme": "light"}, "Theme should switch to light" | ||
|
|
||
| def test_toggle_theme_with_invalid_state(): | ||
| """Test toggling with invalid/missing state""" | ||
| result = toggle_theme(1, None) | ||
| assert result == {"theme": "dark"}, "Invalid state should default to dark" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting errors in dash when running this locally:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devloai do you see what could be causing the problem here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into the theme switching error - seems like we have a null reference issue with the theme object. Will investigate and push a fix shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DanH-Walpole! I've identified and fixed the issue you're experiencing. The problem was related to case sensitivity in the theme stylesheet selectors.
The error
null is not an object (evaluating 'lightTheme.disabled = true')occurred because the JavaScript code was trying to find stylesheets using uppercase theme names (MINTYandDARKLY), but the actual stylesheet URLs contain lowercase names.I've made the following fix:
'link[href*="MINTY"]'to'link[href*="minty"]''link[href*="DARKLY"]'to'link[href*="darkly"]'The changes have been committed and pushed to the branch. All tests are passing, and the theme toggle should now work correctly. Could you please verify that the error is resolved on your local environment?