Skip to content

Fix/pwm reorder #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oganigl merged 5 commits into from
May 11, 2026
Merged

Fix/pwm reorder #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e21f21b
fix(PWM): Reorder members to make it compile
FoniksFox May 8, 2026
5a76e93
chore: Add changeset
FoniksFox May 8, 2026
8de139c
style: just style
FoniksFox May 8, 2026
2ec8b43
Merge branch 'development' into fix/pwm-reorder
FoniksFox May 11, 2026
f192ae1
Merge branch 'development' into fix/pwm-reorder
FoniksFox May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changesets/fix-pwm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
release: patch
summary: Fix reorder issue in PWM constructor
6 changes: 3 additions & 3 deletions Inc/HALAL/Services/PWM/PWM.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ template <const TimerDomain::Timer& dev, const ST_LIB::TimerPin pin> class PWM {
friend TimerWrapper<dev>;

TimerWrapper<dev>* timer;
uint32_t* frequency;
uint32_t polarity;
uint32_t negated_polarity;
float* duty_cycle = nullptr;
uint32_t* frequency;
bool is_on = false;
bool is_initialized = false;
uint32_t polarity;
uint32_t negated_polarity;

/* This constructor is private for a reason. Use TimerWrapper<dev>::get_pwm */
PWM(TimerWrapper<dev>* tim,
Expand Down
Loading