Open
Conversation
…rvice to separate file
flavioislima
approved these changes
Mar 11, 2025
Contributor
flavioislima
left a comment
flavioislima
left a comment
There was a problem hiding this comment.
Code looks good, I believe it is important to test this on all platforms and with the artifact just to be sure it won't break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disclaimer This is still a bit of a WIP needing testing and error handling double checked
Runs the
ExtractZipServicein a worker thread b wrappingExtractZipServicewithExtractZipServiceWrapperKey benefits:
process.noAsarcan be modified without affecting the main threadcloses https://github.com/HyperPlay-Gaming/px-pm/issues/112