fix(redesign): R34 CI fix + gen-over-gen QA pipeline + inbox stagger animations#371
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🤖 Augment PR SummarySummary: This PR fixes the PR demo video CI workflow, upgrades the interactive Gemini QA pipeline to support gen-over-gen milestone tracking, and adds inbox list stagger animations with smoother surface transitions. Changes:
Technical Notes: The comparison output now records both milestone diffs and per-generation aggregates, and prints compact grouped trajectories by generation to make long QA histories easier to interpret. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| if (!prevFingerprints.has(fp)) { | ||
| const detail = currFpMap.get(fp); | ||
| // Check if this is actually a stochastic re-flag (appeared in older rounds, disappeared, reappeared) | ||
| const isStochastic = allHistoryFingerprints.has(fp) && !prevFingerprints.has(fp); |
There was a problem hiding this comment.
scripts/ui/interactiveGeminiQaPipeline.mjs:877 — isStochastic is true for any fingerprint seen in older history, so a true regression after a long gap can be reported as both stochastic (with a “not a real regression” note) and regressed. Consider making the stochastic vs regression buckets mutually exclusive so the report doesn’t contradict itself.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| const start = valid[0]; | ||
| const end = valid[valid.length - 1]; | ||
| const delta = end - start; | ||
| const velocity = +(delta / valid.length).toFixed(2); |
There was a problem hiding this comment.
scripts/ui/interactiveGeminiQaPipeline.mjs:717 — velocity is presented later as “per round”, but it’s computed as delta / valid.length, which underestimates per-step change (typically delta / (valid.length - 1)). This can skew downstream flags like the DECLINING threshold that checks velocity < -0.3.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
| run: npm install --legacy-peer-deps |
There was a problem hiding this comment.
.github/workflows/pr-demo-video.yml:57 — Switching to npm install --legacy-peer-deps without a lockfile makes dependency resolution non-deterministic across runs and can introduce flaky CI failures. If the goal is a reliable “record” check, it may be worth ensuring the install step is still reproducible/stable for Playwright recording.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
…animations Fix the `record` CI check failure (pr-demo-video workflow needed npm install instead of npm ci since package-lock.json is gitignored). Upgrade the Gemini QA pipeline with generation-over-generation milestone tracking, semantic P1 fingerprinting, and dimension trend analysis. Add stagger fade-in animations to inbox list items and smoother surface content transitions. - CI: Remove `cache: npm` from setup-node, switch npm ci → npm install - Pipeline: Milestone diff engine (baseline, gen boundaries, midpoint, previous) - Pipeline: Semantic P1 fingerprinting for stochastic variance filtering - Pipeline: Dimension trend arrows with velocity, scenario stability badges - UI: rd-stagger-fade-in keyframe for inbox rows (40ms cascade, 400ms cap) - UI: Transition smoothness on inbox-list, v3-card, inbox-row elements - UI: prefers-reduced-motion respected for new animations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
HomenShum
force-pushed
the
fix/ci-pipeline-upgrade-r34
branch
from
a57b735 to
184daa7
Compare
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
2 participants
Summary
recordcheck failure —pr-demo-video.ymlremovedcache: npm(package-lock.json is gitignored) and switchednpm citonpm install --legacy-peer-depsprefers-reduced-motionrespectedChanges
.github/workflows/pr-demo-video.ymlrecordcheck — no lockfile dependencyscripts/ui/interactiveGeminiQaPipeline.mjssrc/features/redesign/primitives.cssrd-stagger-fade-inkeyframe + surface transitionssrc/features/redesign/surfaces/InboxSurface.tsxVerification
npx tsc --noEmit— 0 errorsnpm run build— clean (23s)Test plan
pr-demo-videoworkflow succeeds on next merged PR🤖 Generated with Claude Code