Conversation
Sorted quit list alphabetically.
|
It seems that the sky-go client is geo-locked to sky account regions, i.e. there is a different client version for UK than for Germany or Austria, however, the only difference is the download path:
I don't know if there is a way to automatically add localization to brew casks? |
| system_command "/usr/bin/open", | ||
| args: ["-a", "#{staged_path}/SkyGoInstaller.app"], | ||
| sudo: false | ||
| end |
There was a problem hiding this comment.
This is not supported in homebrew-cask.
You will either need to set this up as installer manual or find a way for the installer to run headlessly with installer script.
| desc "On-demand TV streaming service" | ||
| homepage "https://www.sky.com/watch/sky-go/all" | ||
|
|
||
| # Homebrew automatically unzips the file. |
There was a problem hiding this comment.
Please remove the superfluous comments.
| @@ -0,0 +1,33 @@ | |||
| cask "sky-go" do | |||
| version :latest | |||
There was a problem hiding this comment.
It would be ideal if there was a way to detect the version.
|
I just started reverse engineering the SkyGoInstaller and found out that it just pulls a standard macOS pkg of the current version, this will allow me use the standard cask system with versioning. I'll try to find out the endpoint where the installer gets the newest version string from and build it into a cask live check. This should allow me to build a full headless pkg cask install script with versioning. I will update the pull request accordingly in the next days. |
3 participants
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.If AI was used to generate or assist with generating the PR:
zapstanza paths.AI was used to help with generating the .rb file, however, all hardcoded strings, file paths, etc. where manually confirmed, verified.