Skip to content

fix(tui): structure approval details and shell previews #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tdccccc wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(tui): structure approval details and shell previews #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b7e0c1
fix(tui): show key tool details prominently in approval popup
tdccccc May 18, 2026
b0402be
fix: address review feedback on approval popup
tdccccc May 18, 2026
a36d8af
fix(tui): cache approval diff preview and resolve workspace paths
tdccccc May 18, 2026
4a38cb2
fix(tui): render tool detail pager with coloured diff lines
tdccccc May 18, 2026
9a7be5e
fix(tui): align approval diff body and stop truncating shell commands
tdccccc May 18, 2026
3763559
fix(tui): structure approval details and shell previews
tdccccc May 19, 2026
522d89d
fix(tui): cache approval preview rendering
tdccccc May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/tui/src/core/engine/turn_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1660,6 +1660,7 @@ impl Engine {
.send(Event::ApprovalRequired {
id: tool_id.clone(),
tool_name: tool_name.clone(),
input: tool_input.clone(),
description: plan.approval_description.clone(),
approval_key,
approval_grouping_key,
Expand Down
1 change: 1 addition & 0 deletions crates/tui/src/core/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ pub enum Event {
ApprovalRequired {
id: String,
tool_name: String,
input: serde_json::Value,
description: String,
/// Exact-argument fingerprint, used to scope *denials* (#1617).
approval_key: String,
Expand Down
4 changes: 4 additions & 0 deletions crates/tui/src/runtime_threads.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4160,6 +4160,7 @@ mod tests {
approval_grouping_key: "test_key".to_string(),
id: "tool_stale".to_string(),
tool_name: "exec_command".to_string(),
input: json!({"command": "stale approval"}),
description: "stale approval".to_string(),
})
.await?;
Expand Down Expand Up @@ -4233,6 +4234,7 @@ mod tests {
approval_grouping_key: "key1".to_string(),
id: "tool_external_allow".to_string(),
tool_name: "exec_command".to_string(),
input: json!({"command": "external allow"}),
description: "external allow".to_string(),
})
.await?;
Expand Down Expand Up @@ -4310,6 +4312,7 @@ mod tests {
approval_grouping_key: "key2".to_string(),
id: "tool_external_deny".to_string(),
tool_name: "exec_command".to_string(),
input: json!({"command": "external deny"}),
description: "external deny".to_string(),
})
.await?;
Expand Down Expand Up @@ -4496,6 +4499,7 @@ mod tests {
approval_grouping_key: "key3".to_string(),
id: "tool_remember".to_string(),
tool_name: "exec_command".to_string(),
input: json!({"command": "remember=true"}),
description: "remember=true".to_string(),
})
.await?;
Expand Down
Loading