Skip to content

fix(engine): report loop guard halt as Failed instead of Completed #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harvey2011888 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(engine): report loop guard halt as Failed instead of Completed #1859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/tui/src/core/engine/turn_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,7 +1872,9 @@ impl Engine {

if let Some(message) = loop_guard_halt {
crate::logging::warn(message.clone());
let _ = self.tx_event.send(Event::status(message)).await;
let _ = self.tx_event.send(Event::status(message.clone())).await;
// 设置 turn_error 以确保最终返回 TurnOutcomeStatus::Failed 而非 Completed
turn_error = Some(message);
break;
}

Expand Down