Conversation
duncdrum
added
enhancement
github_actions
line-o
left a comment
line-o
left a comment
There was a problem hiding this comment.
I went through each commit separately as the changesets where so large.
I see that this allows to follow the development of the tests and the tests we end up with are easy to understand and grouped by the pages they are testing.
I would want to discuss if we need to keep the intermediate steps in the git history or if it would be cleaner and also easier to understand in the future to squash the changes into one ore two.
Especially the fact that a lot of files, commands and settings are first created just to be later removed again is why I think the project would benefit from a cleaned up history.
If we want to
- keep the connection from a test case to the previous test case
I would be in favour of a comment in the test file that refs the original web driver test file - keep the history of the approach taken
I would prefer that to be summarised in text form or that we keep this branch and not delete it.
Happy to hear your thoughts on all this. Just to be clear, I think that the tests will make a change for the better as they are much cleaner in both setup and grouping. So I am looking forward to making this switch.
| ### Check currently installed versions | ||
|
|
||
| 1. node: `node -v` => Should output `v18.18.2` | ||
| 1. node: `node -v` => Should satisfy `package.json` engines (e.g. `>=18.0.0`; the asdf example uses 18.18.2). |
There was a problem hiding this comment.
What is the asdf example that is referred to here?
There was a problem hiding this comment.
seection 1.1 from this readme
- Add Cypress e2e suite with one spec per page and beforeEach(visit) - Add normalizeHeadlineText custom command; use cy.contains for simple headlines - Group specs in subfolders (e.g. conferences by year, countries/archives) - Add @see comments referencing original tests/specs/**/prod_*.spec.js (wdio) - Add .github/workflows/cypress.yml to run Cypress in Firefox against eXist - Update README and add tests/cypress/COVERAGE_COMPARISON.md - Align search new-indexes assertions (China, Tokyo) with 12eb024 (at least N results)
- Increase body-max-line-length from 200 to 250 - Add footer-max-line-length rule set to 150
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
This ports the test from the original 24 wdio specs (
npm test) to cypress.none of the old tests or their dependencies have been removed yet, as requested.
It also adds actually executing the tests on CI using the
joewiz/hsg-projectcontainer.note: the e2e test run is not yet taken into account for automated releases, that still works as before.
OP#290