-
Notifications
You must be signed in to change notification settings - Fork 0
SDK-94: Try to fix pytest-sanity failing due to too many parallel runs and add Python 3.14 support
#226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benglewis
wants to merge
11
commits into
main
Choose a base branch
from
sdk-94-try-to-fix-issues-with-pipelines-due-to-parallel-sanity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SDK-94: Try to fix pytest-sanity failing due to too many parallel runs and add Python 3.14 support
#226
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7a4d281
Try to fix `pytest-sanity` failing due to too many parallel runs and …
benglewis b5ad3ff
Fix concurrency cancel issue
benglewis 09410dc
Fix package installs in Python 3.14 by changing `pydantic` minimum ve…
benglewis c3d0e32
Fix concurrency os mismatch
benglewis a3ca20c
Fix concurrency group
benglewis 568754a
Fix typo in concurrency group
benglewis 8541d00
Drop `DefaultUtility` to match server behavior
benglewis 8b0ed04
Fix vulnerabilities
benglewis 49a84d2
Fix additional vulnerability
benglewis 88621c7
Fix Baz comment
benglewis 2661f41
Ruff format
benglewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Vulnerability Update Guide | ||
|
|
||
| Use this file when updating dependency floors in [pyproject.toml](pyproject.toml) to address vulnerability findings. | ||
|
|
||
| ## Rules | ||
|
|
||
| 1. Keep the dependency line and its vulnerability note together. | ||
| Example: | ||
| ```toml | ||
| "requests>=2.33.0", | ||
| # ⬆️ Required to fix vulnerability CVE-2026-25645 | ||
| ``` | ||
| The up-arrow comment goes immediately below the package line, not above it. | ||
|
|
||
| 2. Mention only the advisory that necessitates the current minimum version. | ||
| If `authlib>=1.6.11` is required because `GHSA-jj8c-mmj3-mmgv` is the first fix at that floor, mention only that advisory. | ||
| Do not list older advisories that are also fixed incidentally by the same newer version. | ||
|
|
||
| 3. Do not keep stale version-history commentary. | ||
| Keep only the final package floor and the advisory tied to that floor. | ||
|
|
||
| 4. Treat major-version upgrades as compatibility risks. | ||
| Before keeping a major bump such as `transformers` or `pytest`, add or run tests that exercise the affected public SDK behavior. | ||
|
|
||
| 5. Prefer the smallest safe version bump that clears the finding. | ||
| If a vulnerability is fixed in `46.0.6`, do not cite it as justification for `46.0.7` unless `46.0.7` is required by another active finding. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Update the minimum version in `pyproject.toml`. | ||
| 2. Place the vulnerability comment immediately below the changed dependency line. | ||
| 3. Recompile the dependency set from `pyproject.toml`. | ||
| Example: | ||
| ```bash | ||
| UV_CACHE_DIR=/tmp/uv-cache uv pip compile pyproject.toml --group dev --group docs --group deploy --extra pandas --extra polars --extra transformers -o /tmp/hirundo-all-requirements.txt | ||
| ``` | ||
| 4. Audit the compiled output. | ||
| Example: | ||
| ```bash | ||
| UV_CACHE_DIR=/tmp/uv-cache uv run pip-audit --no-deps --disable-pip -r /tmp/hirundo-all-requirements.txt -f json | ||
| ``` | ||
| 5. Run validation for compatibility-sensitive changes. | ||
| Commands: | ||
| ```bash | ||
| .venv/bin/pytest | ||
| .venv/bin/basedpyright | ||
| ``` | ||
|
|
||
| ## Repo-specific notes | ||
|
|
||
| - This repository has many integration-heavy tests that require credentials such as `AWS_ACCESS_KEY`, `GCP_CREDENTIALS`, and `HUGGINGFACE_ACCESS_TOKEN`. | ||
| - If full `pytest` is unavailable because credentials are missing, report that explicitly and run any safe targeted tests that cover the changed behavior. | ||
| - For `transformers` changes, keep coverage on the Hugging Face pipeline path in [tests/unlearning-llm/llm_pipeline_transformers_test.py](tests/unlearning-llm/llm_pipeline_transformers_test.py). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.