-
Notifications
You must be signed in to change notification settings - Fork 0
SDK-90: Upgrade trivy-action to @0.35.0 to fix vulnerability
#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5a5183c
b5b7a02
e73be2d
c3ee6b1
23b6920
45b3c30
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Vulnerability Update Guide | ||
|
|
||
| Use this file when updating dependency floors in [pyproject.toml](pyproject.toml) to address vulnerability findings. | ||
|
|
||
| ## Rules | ||
|
|
||
| 1. Keep the dependency line and its vulnerability note together. | ||
| Example: | ||
| ```toml | ||
| "requests>=2.33.0", | ||
| # ⬆️ Required to fix vulnerability CVE-2026-25645 | ||
| ``` | ||
| The up-arrow comment goes immediately below the package line, not above it. | ||
|
|
||
| 2. Mention only the advisory that necessitates the current minimum version. | ||
| If `authlib>=1.6.11` is required because `GHSA-jj8c-mmj3-mmgv` is the first fix at that floor, mention only that advisory. | ||
| Do not list older advisories that are also fixed incidentally by the same newer version. | ||
|
|
||
| 3. Do not keep stale version-history commentary. | ||
| Keep only the final package floor and the advisory tied to that floor. | ||
|
|
||
| 4. Treat major-version upgrades as compatibility risks. | ||
| Before keeping a major bump such as `transformers` or `pytest`, add or run tests that exercise the affected public SDK behavior. | ||
|
|
||
| 5. Prefer the smallest safe version bump that clears the finding. | ||
| If a vulnerability is fixed in `46.0.6`, do not cite it as justification for `46.0.7` unless `46.0.7` is required by another active finding. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Update the minimum version in `pyproject.toml`. | ||
| 2. Place the vulnerability comment immediately below the changed dependency line. | ||
| 3. Recompile the dependency set from `pyproject.toml`. | ||
| Example: | ||
| ```bash | ||
| UV_CACHE_DIR=/tmp/uv-cache uv pip compile pyproject.toml --group dev --group docs --group deploy --extra pandas --extra polars --extra transformers -o /tmp/hirundo-all-requirements.txt | ||
| ``` | ||
| 4. Audit the compiled output. | ||
| Example: | ||
| ```bash | ||
| UV_CACHE_DIR=/tmp/uv-cache uv run pip-audit --no-deps --disable-pip -r /tmp/hirundo-all-requirements.txt -f json | ||
| ``` | ||
| 5. Run validation for compatibility-sensitive changes. | ||
| Commands: | ||
| ```bash | ||
| .venv/bin/pytest | ||
| .venv/bin/basedpyright | ||
| ``` | ||
|
|
||
| ## Repo-specific notes | ||
|
|
||
| - This repository has many integration-heavy tests that require credentials such as `AWS_ACCESS_KEY`, `GCP_CREDENTIALS`, and `HUGGINGFACE_ACCESS_TOKEN`. | ||
| - If full `pytest` is unavailable because credentials are missing, report that explicitly and run any safe targeted tests that cover the changed behavior. | ||
| - For `transformers` changes, keep coverage on the Hugging Face pipeline path in [tests/unlearning-llm/llm_pipeline_transformers_test.py](tests/unlearning-llm/llm_pipeline_transformers_test.py). |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -31,9 +31,9 @@ dependencies = [ | |||||||||||||||||||
| "httpx-sse>=0.4.0", | ||||||||||||||||||||
| "tqdm>=4.66.5", | ||||||||||||||||||||
| "h11>=0.16.0", | ||||||||||||||||||||
| "requests>=2.33.0", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability GHSA-vqfr-h8mv-ghfj | ||||||||||||||||||||
| "requests>=2.32.4", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability GHSA-9hjg-9r4m-mvj7 | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability CVE-2026-25645 | ||||||||||||||||||||
|
Comment on lines
33
to
36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably by mistake :)
Suggested change
|
||||||||||||||||||||
| "urllib3>=2.6.3", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability CVE-2026-21441 | ||||||||||||||||||||
| "setuptools>=78.1.1", | ||||||||||||||||||||
|
|
@@ -51,28 +51,34 @@ Homepage = "https://github.com/Hirundo-io/hirundo-python-sdk" | |||||||||||||||||||
| [project.optional-dependencies] | ||||||||||||||||||||
| pandas = ["pandas>=2.2.3"] | ||||||||||||||||||||
| polars = ["polars>=1.0.0"] | ||||||||||||||||||||
| transformers = ["transformers>=4.57.3", "peft>=0.18.1", "accelerate>=1.12.0"] | ||||||||||||||||||||
| transformers = [ | ||||||||||||||||||||
| "transformers>=5.0.0rc3", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability CVE-2026-1839 | ||||||||||||||||||||
| "peft>=0.18.1", | ||||||||||||||||||||
| "accelerate>=1.12.0", | ||||||||||||||||||||
|
Comment on lines
+54
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since Finding type: Prompt for AI Agents: |
||||||||||||||||||||
| ] | ||||||||||||||||||||
|
|
||||||||||||||||||||
| [dependency-groups] | ||||||||||||||||||||
| dev = [ | ||||||||||||||||||||
| "hirundo[pandas,polars,transformers]", | ||||||||||||||||||||
| "numpy>=2.1.3; sys_platform == 'darwin'", | ||||||||||||||||||||
| # ⬆️ Ensure macOS runners resolve a NumPy version with prebuilt wheels in `pytest_sanity`. | ||||||||||||||||||||
| "types-setuptools>=69.5.0", | ||||||||||||||||||||
| "pytest>=8.2.0", | ||||||||||||||||||||
| "pytest>=9.0.3", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability CVE-2025-71176 | ||||||||||||||||||||
| "pytest-asyncio>=0.23.6", | ||||||||||||||||||||
| "uv>=0.9.29", | ||||||||||||||||||||
| "uv>=0.11.6", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability GHSA-pjjw-68hj-v9mw | ||||||||||||||||||||
| "pre-commit>=3.7.1", | ||||||||||||||||||||
| "basedpyright==1.37.1", | ||||||||||||||||||||
| "virtualenv>=20.36.1", | ||||||||||||||||||||
| # ⬆️ Needed for `pre-commit` version fix for vulnerability GHSA-rqc4-2hc7-8c8v | ||||||||||||||||||||
| "authlib>=1.6.6", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability CVE-2025-68158 | ||||||||||||||||||||
| "authlib>=1.6.11", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability GHSA-jj8c-mmj3-mmgv | ||||||||||||||||||||
| "ruff>=0.12.0", | ||||||||||||||||||||
| "bumpver>=2025.1131", | ||||||||||||||||||||
| "platformdirs>=4.3.6", | ||||||||||||||||||||
| "cryptography>=46.0.5", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability CVE-2026-26007 | ||||||||||||||||||||
| "cryptography>=46.0.7", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerability CVE-2026-39892 | ||||||||||||||||||||
| "jinja2>=3.1.6", | ||||||||||||||||||||
| # ⬆️ Required to fix vulnerabilities GHSA-cpwx-vrp4-4pq7 , GHSA-gmj6-6f8f-6699 & GHSA-q2x7-8rv6-6q7h | ||||||||||||||||||||
| "filelock>=3.20.3", | ||||||||||||||||||||
|
|
||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.