SDK-43: Add LLM unlearning support#185
Closed
benglewis wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
This doesn't look right... Lots of things are off |
| f"{API_HOST}/llm/model/", | ||
| headers=get_headers(), | ||
| timeout=READ_TIMEOUT, | ||
| params={"organization_id": organization_id} if organization_id else None, |
There was a problem hiding this comment.
Truthiness check ignores zero organization ID value
Low Severity
The list_models and list_datasets methods use a truthiness check (if organization_id) instead of an explicit None check. This causes organization_id=0 to be treated as falsy and silently ignored. The type annotation int | None allows zero, and the create() methods in the same file correctly use if organization_id is not None:. This inconsistency could lead to unexpected behavior when explicitly filtering by organization ID zero.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
feature: SDK-43
Codex Task
Note
Adds a new
hirundo.llmmodule to manage LLM resources and unlearning.BiasType/BiasRunInfofor configuring unlearning runsHuggingFaceTransformersModelandLlmModelwith create/list/get/delete and server payload serializationUnlearningExampleandLlmUnlearningDatawith create/list/get/delete for unlearning datasetsLlmUnlearningRunwithlaunchandgetfor run lifecycle__init__Written by Cursor Bugbot for commit c44cf64. Configure here.