Clnt-61: Fix missing permissions in GitHub actions workflows, fix dataset-optimization to data-qa API renaming & fix package vulnerabilities#141
Merged
benglewis merged 8 commits intoAug 3, 2025
Conversation
… which we now use instead of `pyright`
This is because dataset optimization was renamed to dataset QA
…o dataset / data QA This matches the renaming done to our GUI client and API Also fixed incorrect old Hirundo CSV column name of `label` -> `class_name`
permissions in GitHub actions workflows, fix dataset-optimization to data-qa API renaming & fix package vulnerabilities
…passed as speech with speech to text runs to avoid failures
Contributor
|
I just saw things that might pop when the ruff format checks will run. Other than that LGTM. |
Contributor
Author
Thank you for the heads up. Fixed |
eayar123
approved these changes
Aug 3, 2025
Contributor
eayar123
left a comment
There was a problem hiding this comment.
there was not a problem with ruff - LGTM.
mishana
approved these changes
Aug 3, 2025
Contributor
mishana
left a comment
There was a problem hiding this comment.
Lgtm, please see one question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Bito
This pull request enhances the project's maintainability and security by updating package dependencies to address vulnerabilities, refactoring dataset-related classes for clarity, and improving GitHub Actions workflows with necessary permissions. It also cleans up configuration files by removing unused dependencies and improving comments, thereby enhancing overall functionality and maintainability.