Skip to content

Clnt-61: Fix missing permissions in GitHub actions workflows, fix dataset-optimization to data-qa API renaming & fix package vulnerabilities#141

Merged
benglewis merged 8 commits into
mainfrom
clnt-61-fix-missing-permissions-in-github-actions-workflows
Aug 3, 2025
Merged

Clnt-61: Fix missing permissions in GitHub actions workflows, fix dataset-optimization to data-qa API renaming & fix package vulnerabilities#141
benglewis merged 8 commits into
mainfrom
clnt-61-fix-missing-permissions-in-github-actions-workflows

Conversation

@benglewis
Copy link
Copy Markdown
Contributor

@benglewis benglewis commented Aug 3, 2025

Summary by Bito

This pull request enhances the project's maintainability and security by updating package dependencies to address vulnerabilities, refactoring dataset-related classes for clarity, and improving GitHub Actions workflows with necessary permissions. It also cleans up configuration files by removing unused dependencies and improving comments, thereby enhancing overall functionality and maintainability.

@benglewis benglewis requested a review from eayar123 August 3, 2025 09:16
@benglewis benglewis self-assigned this Aug 3, 2025
This is because dataset optimization was renamed to dataset QA
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment bugbot run to trigger another review on this PR

Comment thread hirundo/dataset_optimization.py
…o dataset / data QA

This matches the renaming done to our GUI client and API
Also fixed incorrect old Hirundo CSV column name of `label` -> `class_name`
@benglewis benglewis changed the title Clnt-61: Fix missing permissions in GitHub actions workflows Clnt-61: Fix missing permissions in GitHub actions workflows, fix dataset-optimization to data-qa API renaming & fix package vulnerabilities Aug 3, 2025
…passed as speech with speech to text runs to avoid failures
@eayar123
Copy link
Copy Markdown
Contributor

eayar123 commented Aug 3, 2025

I just saw things that might pop when the ruff format checks will run. Other than that LGTM.

@benglewis
Copy link
Copy Markdown
Contributor Author

I just saw things that might pop when the ruff format checks will run. Other than that LGTM.

Thank you for the heads up. Fixed

Copy link
Copy Markdown
Contributor

@eayar123 eayar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was not a problem with ruff - LGTM.

Comment thread tests/classification/classification_aws_test.py
Comment thread tests/classification/classification_gcp_test.py
Comment thread tests/classification/sanity_gcp_test.py
Copy link
Copy Markdown
Contributor

@mishana mishana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, please see one question

Comment thread tests/object-detection/sanity_aws_test.py
@benglewis benglewis merged commit 830ddb2 into main Aug 3, 2025
29 checks passed
@benglewis benglewis deleted the clnt-61-fix-missing-permissions-in-github-actions-workflows branch August 3, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants