refactor: remove bcrypt dependency and simplify password handling in …

.github/workflows/deployVPS.yaml

@@ -46,7 +46,6 @@ jobs:
           docker build \
           --build-arg REACT_APP_BACKEND_URL=${{ secrets.BACKEND_URL }} \
           --build-arg REACT_APP_BACKEND_PORT=${{ secrets.BACKEND_PORT }} \
-          --build-arg REACT_APP_SALT_HASH=${{ secrets.BACKEND_SALT }} \
           -t ${{ secrets.DOCKER_IMAGE_NAME }}:${{ env.IMAGE_TAG }} .
 
       - name: Push Docker image (Docker Hub)

README.md

@@ -21,7 +21,6 @@ Create a `.env` file at the root of the project with the following variables:
 ```
 REACT_APP_BACKEND_URL= [Database URL]
 REACT_APP_BACKEND_PORT= [Database port]
-REACT_APP_SALT_HASH= [SALT HASH used for the password]
 ```
 
 ## 🚀 Running the Project

package.json

@@ -11,7 +11,6 @@
     "@mui/material": "^7.0.1",
     "@mui/x-data-grid": "^7.28.2",
     "@testing-library/user-event": "^13.5.0",
-    "bcryptjs-react": "^2.4.6",
     "eslint-plugin-jest": "^25.7.0",
     "jest-localstorage-mock": "^2.4.26",
     "react": "^18.3.1",

src/Components/Manager/UserManagement/SideViewUser.js

@@ -9,7 +9,6 @@ import {
 import { ExpandMore, SaveRounded } from "@mui/icons-material";
 import React, { useEffect, useState } from "react";
 import { useNavigate } from "react-router-dom";
-import bcrypt from "bcryptjs-react";
 import PropTypes from "prop-types";
 
 /**
@@ -76,10 +75,7 @@ function SideViewUser({ user, setAlert, refreshData }) {
       ...newUser,
       ...(isNewUser &&
         password.password && {
-          password: bcrypt.hashSync(
-            password.password,
-            process.env.REACT_APP_SALT_HASH
-          ),
+          password: password.password
         }),
     };
 
@@ -108,14 +104,8 @@ function SideViewUser({ user, setAlert, refreshData }) {
                 Authorization: `Bearer ${localStorage.getItem("token")}`,
               },
               body: JSON.stringify({
-                oldPassword: bcrypt.hashSync(
-                  password.oldPassword,
-                  process.env.REACT_APP_SALT_HASH
-                ),
-                newPassword: bcrypt.hashSync(
-                  password.password,
-                  process.env.REACT_APP_SALT_HASH
-                ),
+                oldPassword: password.oldPassword,
+                newPassword: password.password,
               }),
             }
           );

src/Pages/Login/Login.js

@@ -1,7 +1,5 @@
 import React, { useState, useEffect } from "react";
 import { useNavigate, useLocation } from "react-router-dom";
-// import logo from './logo-notext.png';
-import bcrypt from "bcryptjs-react";
 
 /**
  * Component : Page, Component used to handle a User login in the POS Application. Main entry point
@@ -31,10 +29,8 @@ const Login = () => {
             return;
         }
 
-        const hasedPassword = bcrypt.hashSync(password, `${process.env.REACT_APP_SALT_HASH}`);
 
-
-        fetch(`${process.env.REACT_APP_BACKEND_URL}:${process.env.REACT_APP_BACKEND_PORT}/api/login?idRestaurant=${restaurantID}&username=${username}&password=${hasedPassword}`)
+        fetch(`${process.env.REACT_APP_BACKEND_URL}:${process.env.REACT_APP_BACKEND_PORT}/api/login?idRestaurant=${restaurantID}&username=${username}&password=${password}`)
             .then(response => {
                 if (response.status === 400)
                     setError('Username or password is incorrect');