Remove Odyssey from termination flow#2885
Draft
hugokallstrom wants to merge 19 commits intodevelopfrom
Draft
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…calls Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… query Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ackend call Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…act mutation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace Odyssey flow-based navigation with client-driven routing. Survey VMs now receive action upfront, navigateFromSurvey() routes based on suggestion type and termination action. Thread selectedReasonId and feedbackComment through to confirmation. Add DeflectSuggestion placeholder destination. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove TerminationFlowContextStorage, DeflectAutoDecommissionStepViewModel, and FeatureManager dependencies. Repository now only needs ApolloClient. Survey VM receives action and contractId. Confirmation VM receives selectedReasonId and feedbackComment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…bles Remove 7 old flow-based GraphQL operations and 3 deflect step files. Update ChooseInsuranceToTerminateDestination, TerminationSurveyDestination, and TerminationConfirmationDestination to use new data models and callback signatures matching the rewritten ViewModels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove coreDatastorePublic, dataProductVariantPublic, featureFlagsPublic, and navigationActivity now that TerminationFlowContextStorage and FeatureManager are no longer used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rewrite TerminationSurveyPresenterTest to use new constructor (options, action, changeTierRepository, contractId) and test local navigation instead of repository-driven steps. Stub out repository test until new GraphQL schema is deployed. Remove unused test dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Create DeflectSuggestionDestination composable replacing the old separate DeflectAutoCancel and DeflectAutoDecom screens. Supports both AUTO_CANCEL (dismiss only) and AUTO_DECOMMISSION (continue termination or dismiss) suggestion types. Wire it up in the nav graph. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix line length violations, parameter wrapping, import ordering, and remove empty test file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use a wrapper type (TerminationSuccessResult) instead of bare LocalDate? so that deletions (null terminationDate) properly trigger navigation to the success screen. Show userError as a notification card on the confirmation screen. Use generic "continue" button text for suggestions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update mutation to use terminationSurveyOptionId instead of terminationReason enum. Update notification query from Contract.terminationBundleDiscountNotification to Member.terminationFlowNotification per underwriter PRs #1681/#1682. Add TerminationSurveyOptionId scalar mapping. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…loys The scalar doesn't exist in the current schema yet, so the mapping breaks Apollo codegen. It will be added back when the schema is updated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminationSurveyquery andterminateContractmutation (both served by Underwriter, which internally delegates to Product-Pricing for contract state changes)DeflectSuggestiondestination replacing separateDeflectAutoCancelandDeflectAutoDecomscreensWhat changed
TerminationSurveyData/TerminationAction/TerminationResultreplacing deepTerminateInsuranceStepsealed hierarchygetTerminationSurvey,terminateContract) replacing 6 flow-based methodsterminateContractdirectly with reason/commentTerminationFlowContextStorage,FeatureManager,DataStoredependenciesBlocked on
terminationSurveyquery andterminateContractmutation types don't exist in the schema yet. Build will fail on Apollo codegen until schema is updated.Test plan
./gradlew downloadOctopusApolloSchemaFromIntrospectionand fix any codegen mismatches./gradlew :feature-terminate-insurance:test🤖 Generated with Claude Code