Skip to content

Integration of Trd pid#5

Merged
lubynets merged 9 commits into
HeavyIonAnalysis:masterfrom
SusanneGlaessel:master
Jan 15, 2026
Merged

Integration of Trd pid#5
lubynets merged 9 commits into
HeavyIonAnalysis:masterfrom
SusanneGlaessel:master

Conversation

@SusanneGlaessel
Copy link
Copy Markdown
Contributor

The TRD pid is integrated in the following way:

The Pid framework contains two steps for the Tof pid:

  1. Calculating MC-probabilities / fitting
  2. Filling

The integrated Trd pid consists of three steps:
Preparation: Creating MC histograms

  1. Calculating MC-probabilities
  2. Filling

The preparation and step 1) are performed independently of each other for both detector pids.

Step 2) is now combined - the filling of both pids can be done simultaneously. It is still possible to run only one of the detector pids by using the same executable. The selection of what pid to run, is handled by the first argument of the executable (see README.md for more details.).

Comment thread macro/RunGetterTrd.C Outdated
Comment thread macro/rootlogon.C Outdated
Comment thread src_trd/CMakeLists.txt Outdated
Comment thread src_trd/ContainerTrd.h Outdated
Comment thread src_trd/GetterTrd.cpp Outdated
Comment thread src_trd/GetterTrd.h Outdated
Comment thread macro/RunGetterTof.C
Comment thread at_interface/PidFiller.hpp Outdated
Comment thread src_trd/ContainerTrd.h Outdated
Comment thread tasks/calculate_mcprob_trd.cpp Outdated
@lubynets
Copy link
Copy Markdown
Contributor

lubynets commented Jan 9, 2026

Dear @SusanneGlaessel, thanks for the extensive development!

  1. Please consider my comments which I left in the code.
  2. Remove the files .DS_Store from the PR and add them to .gitignore so git will not include them any more (those which are already included you need to remove from git index manually).
  3. Adapt the clang-format workflow to the changed naming of directories (link), and apply clang-format locally before updating the PR.

Copy link
Copy Markdown
Contributor

@lubynets lubynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SusanneGlaessel thanks for addressing my comments!
I still have minor comments/suggestions which I left in the code.

Comment thread Pid_with_TRD_dEdx.pdf Outdated
Comment thread macro/RunGetterTrd.C Outdated
Comment thread src_trd/GetterTrd.cpp Outdated
Comment thread macro/RunGetterTof.C
Comment thread src_trd/GetterTrd.cpp
Comment thread src_trd/GetterTrd.cpp
@SusanneGlaessel
Copy link
Copy Markdown
Contributor Author

Dear @lubynets,
thank you very much for checking the code and for your comments.
I have incorporated now everything, just that one line pid = TMath::Sign(1, charge); I left like it is (see comment). Is it ok for you?
Thank you and kind regards,
Susanne

Comment thread Pid_with_TRD_dEdx.pdf Outdated
Comment thread at_interface/CMakeLists.txt Outdated
@lubynets
Copy link
Copy Markdown
Contributor

@SusanneGlaessel thanks again for the development, and for processing my comments and suggestions!

@lubynets lubynets merged commit c60d6c0 into HeavyIonAnalysis:master Jan 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants