Add fileExtensions to configuration to allow formatting of other haxe source files#696
Open
ninjamuffin99 wants to merge 2 commits intoHaxeCheckstyle:masterfrom
Open
Add fileExtensions to configuration to allow formatting of other haxe source files#696ninjamuffin99 wants to merge 2 commits intoHaxeCheckstyle:masterfrom
fileExtensions to configuration to allow formatting of other haxe source files#696ninjamuffin99 wants to merge 2 commits intoHaxeCheckstyle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now haxe-formatter is hard coded to only parse
.hxfiles, unless you use the CLI's-e / --extensionargument, in which case you will have to run it multiple times for each potential file type.This PR adds a config option
fileExtensionsthat allows a developer to configure which file types haxe-formatter will attempt to process.Usecase is sometihng like OpenFL/Lime's
.hxpfile which is an alternative to theirproject.xml, which lets you setup project stuff in haxe code. Right now haxe-formatter doesn't allow any configuration to let itself know that this is a valid file type.Another example is how Friday Night Funkin' separates it's hscript files, into
.hxcfiles, which again are just haxe files, with a different extension.This is my first time poking into this code base, so if there's something I missed with this PR, tests, different code style, let me know!