Conversation
The reusable's auto-derive of the called-workflow ref doesn't work: in a workflow_call context, github.workflow_ref resolves to the CALLER's ref (e.g. refs/pull/72/merge), not the called workflow's ref. The reusable then tries to check out HarperFast/ai-review-prompts at refs/pull/72/merge and fails: "couldn't find remote ref". Until GitHub exposes the called-workflow ref to reusables, the caller passes the SHA explicitly via the existing ai-review-prompts-ref input (already supported as an override). The pin lives in two places now, but they bump together. Followup: HarperFast/ai-review-prompts will drop the broken auto-derive once both callers (oauth + harper) are passing the input explicitly.
heskew
added a commit
to HarperFast/harper
that referenced
this pull request
May 6, 2026
Same fix as oauth#73: the reusable's auto-derive of the called- workflow ref doesn't work in workflow_call context (github.workflow_ref resolves to the CALLER's ref). Pass the SHA explicitly via the existing ai-review-prompts-ref input until the followup PR drops the broken auto-derive. See HarperFast/oauth#73 for the prior art and rationale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai-review-prompts-refexplicitly to the reusable, matching the SHA in theuses:ref pin.Why
The reusable workflow auto-derives the ref by parsing
github.workflow_ref, but in aworkflow_callcontext that variable resolves to the caller's ref (e.g.refs/pull/72/merge), not the called workflow's ref. The reusable then tries to check outHarperFast/ai-review-promptsatrefs/pull/72/mergeand fails:See https://github.com/HarperFast/oauth/actions/runs/25410329060 for the failed run on #72.
The reusable already supports
ai-review-prompts-refas an explicit input override. This PR uses it.Followup
HarperFast/ai-review-promptsand make the input required.Test plan
yqparses cleanly)🤖 Generated with Claude Code