feat: support harper-pro distribution in integration tests#38
Draft
Ethan-Arrowood wants to merge 1 commit intomainfrom
Draft
feat: support harper-pro distribution in integration tests#38Ethan-Arrowood wants to merge 1 commit intomainfrom
Ethan-Arrowood wants to merge 1 commit intomainfrom
Conversation
- fixture.ts reads HARPER_DISTRIBUTION env var to switch between the `harper` (default) and `@harperfast/harper-pro` packages when resolving the Harper binary path - add `test:integration:harper-pro` npm script as a convenience wrapper that sets HARPER_DISTRIBUTION=harper-pro before running Playwright - workflow: split integration-tests job into two named jobs (integration-tests-harper, integration-tests-harper-pro) each with their own Node-version matrix so runners are not overloaded; add a `distribution` workflow_dispatch input for targeted manual runs; workflow remains disabled (if: false on generate-matrix) while the broader CI setup is being fixed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integrationTests/fixture.ts:getHarperBinPath()now readsHARPER_DISTRIBUTIONenv var — defaults toharper, switches to@harperfast/harper-pro(dist/bin/harper.js) when set toharper-propackage.json: newtest:integration:harper-proscript setsHARPER_DISTRIBUTION=harper-proso you can runnpm run test:integration:harper-pro(or pass a specific file:npm run test:integration:harper-pro -- integrationTests/next-16.pw.ts).github/workflows/integration-tests.yml: split the singleintegration-testsjob into two named jobs (integration-tests-harper,integration-tests-harper-pro) each with their ownnode-versionmatrix — 3 Node versions × 2 distributions = 6 runners running in parallel, keeping each runner focused; added adistributionworkflow_dispatch input for targeted manual runs; workflow remains disabled (if: falseongenerate-matrix) while the broader CI fix is in progressLocal usage
Test plan
npm run test:integrationresolves to theharperbin (no env var set)npm run test:integration:harper-proresolves to@harperfast/harper-pro/dist/bin/harper.jsharper-logs-harper-*vsharper-logs-harper-pro-*)🤖 Generated with Claude Code