Draft
Conversation
Contributor
|
Reviewed; no blockers found. |
kriszyp
reviewed
May 6, 2026
Member
kriszyp
left a comment
There was a problem hiding this comment.
The RocksDB record and LMDB records don't really have the same binary format. The RocksDB record starts with the version timestamp (because we decided to not include that natively like lmdb-js does), and then LMDB typically has encoding of id/timestamp reference into the audit log. So I wouldn't think this would work.
I would think the LMDB audit log error probably needs to be addressed regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created an database using LMDB storage and then inserted a bunch of rows. Next I ran
harper copy-db testdb testdb2and it errored with:When opening the source and target databases, set the encoding to binary so that we completely bypass decoding/encoding and do a true byte copy.