Skip to content

add acl-connect component integration test#426

Open
ldt1996 wants to merge 7 commits intomainfrom
acl-connect-integration-test
Open

add acl-connect component integration test#426
ldt1996 wants to merge 7 commits intomainfrom
acl-connect-integration-test

Conversation

@ldt1996
Copy link
Copy Markdown
Contributor

@ldt1996 ldt1996 commented Apr 29, 2026

closes #364

@ldt1996 ldt1996 requested a review from a team as a code owner April 29, 2026 22:43
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 29, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​harperdb/​acl-connect@​1.0.10671008192100

View full report

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 29, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Publisher changed: npm @harperdb/acl-connect is now published by ethan_arrowood

Author: ethan_arrowood

From: integrationTests/components/fixtures/acl-connect-with-sys/package.jsonnpm/@harperdb/acl-connect@1.0.10

ℹ Read more on: This package | This alert | What is unstable ownership?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Try to reduce the number of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@harperdb/acl-connect@1.0.10. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Low adoption: npm @harperdb/acl-connect

Location: Package overview

From: integrationTests/components/fixtures/acl-connect-with-sys/package.jsonnpm/@harperdb/acl-connect@1.0.10

ℹ Read more on: This package | This alert | What are unpopular packages?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Unpopular packages may have less maintenance and contain other problems.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@harperdb/acl-connect@1.0.10. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@ldt1996 ldt1996 force-pushed the acl-connect-integration-test branch from 29b75e7 to 5ecc6b8 Compare April 29, 2026 23:12
Copy link
Copy Markdown
Member

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! just some esm nits but good to go otherwise.

Comment on lines +4 to +5
const require = createRequire(import.meta.url);
const SETTINGS = require('./connect.json');
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const require = createRequire(import.meta.url);
const SETTINGS = require('./connect.json');
import SETTINGS from './connect.json' with { type: 'json' };

https://nodejs.org/api/esm.html#json-modules

import { startHarper, teardownHarper, sendOperation, type ContextWithHarper } from '@harperfast/integration-testing';

const PROJECT = 'acl-connect-with-sys';
const __dirname = dirname(fileURLToPath(import.meta.url));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does import.meta.dirname work instead? Or are we not treating these tests as ESM 🤔

Copy link
Copy Markdown
Member

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I agree with Ethan's findings.

@ldt1996 ldt1996 force-pushed the acl-connect-integration-test branch from 54ed637 to 645bff7 Compare May 4, 2026 15:07
@ldt1996
Copy link
Copy Markdown
Contributor Author

ldt1996 commented May 4, 2026

thank you for your comments @Ethan-Arrowood , I agree with all of them, updated accodringly

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 4, 2026

Reviewed; no blockers found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component integration test: acl-connect

3 participants