Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
29b75e7 to
5ecc6b8
Compare
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
very nice! just some esm nits but good to go otherwise.
| const require = createRequire(import.meta.url); | ||
| const SETTINGS = require('./connect.json'); |
There was a problem hiding this comment.
| const require = createRequire(import.meta.url); | |
| const SETTINGS = require('./connect.json'); | |
| import SETTINGS from './connect.json' with { type: 'json' }; |
| import { startHarper, teardownHarper, sendOperation, type ContextWithHarper } from '@harperfast/integration-testing'; | ||
|
|
||
| const PROJECT = 'acl-connect-with-sys'; | ||
| const __dirname = dirname(fileURLToPath(import.meta.url)); |
There was a problem hiding this comment.
Does import.meta.dirname work instead? Or are we not treating these tests as ESM 🤔
cb1kenobi
left a comment
There was a problem hiding this comment.
Looks good, though I agree with Ethan's findings.
54ed637 to
645bff7
Compare
|
thank you for your comments @Ethan-Arrowood , I agree with all of them, updated accodringly |
|
Reviewed; no blockers found. |
closes #364