Skip to content

Custom Item Icons in Textboxes#6343

Merged
serprex merged 8 commits intoHarbourMasters:developfrom
leggettc18:feat/randomizer/custom-item-icons
Mar 20, 2026
Merged

Custom Item Icons in Textboxes#6343
serprex merged 8 commits intoHarbourMasters:developfrom
leggettc18:feat/randomizer/custom-item-icons

Conversation

@leggettc18
Copy link
Copy Markdown
Contributor

@leggettc18 leggettc18 commented Mar 11, 2026

Adds a way to support custom item icons in textboxes (i.e. Boss Souls, Roc's Feather, etc.) Currently implemented for Rando get item textboxes.
Screenshot_20260310_204107

Build Artifacts

@serprex serprex self-requested a review March 12, 2026 04:36
Comment thread soh/soh/Enhancements/randomizer/Messages/ItemMessages.cpp Outdated
Copy link
Copy Markdown
Contributor Author

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few comments of my own to add to the pile, also thinking about it now, Roc's Feather could be broken, at least visually on the pause screen, so I need to double check that. Also I keep trying to make Deku Stick Bag and Deku Nut Bag (the initial ones) have an icon, but I keep guessing the wrong RGIDs for that lol. Putting this on draft for now, but still feel free to playtest/review, it won't be long.

Comment thread soh/soh/Enhancements/randomizer/Messages/ItemMessages.cpp Outdated
Comment thread soh/soh/Enhancements/randomizer/item.h Outdated
@leggettc18 leggettc18 marked this pull request as draft March 12, 2026 13:03
@leggettc18 leggettc18 marked this pull request as ready for review March 13, 2026 01:44
@serprex serprex merged commit 5c8ff76 into HarbourMasters:develop Mar 20, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants