Fix Box Drawing Character Centering#57
Conversation
When stretching box drawing characters vertically to fill the lineheight, they were only stretching upwards from the baseline, which resulted in them not extending below the baseline properly. This commit ensures that the stretching is centered around the middle of the cell. - In `src/render_gif.rs`, offset the `py` coordinate of box drawing characters by `cell_center_y - box_center_y`. - In `src/render_svg.rs`, center the SVG `<text>` elements representing box drawing characters around `cell_center_y`. Co-authored-by: HalFrgrd <4559349+HalFrgrd@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes the vertical centering of stretched box drawing characters in both SVG and GIF outputs.
PR created automatically by Jules for task 18121838303288365216 started by @HalFrgrd