Skip to content

Replace deprecated font-noto-sans-cjk on macOS and add manual workflow trigger#948

Merged
HackingGate merged 4 commits into
mainfrom
copilot/fix-font-deprecation-macos
Jan 13, 2026
Merged

Replace deprecated font-noto-sans-cjk on macOS and add manual workflow trigger#948
HackingGate merged 4 commits into
mainfrom
copilot/fix-font-deprecation-macos

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 13, 2026

The font-noto-sans-cjk Homebrew cask is deprecated and will be disabled on 2026-11-22.

Changes

Font Deprecation Fix

  • Replaced single deprecated cask with individual language-specific fonts:
    • font-noto-sans-cjk-tc (Traditional Chinese)
    • font-noto-sans-cjk-jp (Japanese)
    • font-noto-sans-cjk-kr (Korean)

These correspond exactly to the three Noto Sans CJK variants used in the test suite.

# Before
brew install --cask font-noto-sans-cjk

# After
brew install --cask font-noto-sans-cjk-tc font-noto-sans-cjk-jp font-noto-sans-cjk-kr

Manual Workflow Trigger

  • Added workflow_dispatch event trigger to enable manual CI runs
  • Added input parameters:
    • Operating System: Dropdown to select specific OS or all (ubuntu-latest, macos-latest, windows-latest, or all)
    • Typst version: Optional text field to test specific version (defaults to all versions if empty)
  • Updated detect-changes job to handle manual triggers with appropriate matrix configuration

Usage

To manually trigger the workflow:

  1. Navigate to Actions → "Test Typst Out Action"
  2. Click "Run workflow"
  3. Select desired OS (default: all)
  4. Optionally specify Typst version (default: all versions)
  5. Click "Run workflow"
Original prompt

This section details on the original issue you should resolve

<issue_title>Font deprecation on macOS runner</issue_title>
<issue_description>CI warning
For macOS runner
font-noto-sans-cjk has been deprecated because it is discontinued upstream! It will be disabled on 2026-11-22.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 13, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

…ic fonts

Co-authored-by: HackingGate <8541644+HackingGate@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix font deprecation warning on macOS runner Replace deprecated font-noto-sans-cjk with language-specific fonts on macOS Jan 13, 2026
Copilot AI requested a review from HackingGate January 13, 2026 15:36
@HackingGate
Copy link
Copy Markdown
Owner

@copilot
Enable manual trigger of CI, and OS selection if possible.

Copilot AI and others added 2 commits January 13, 2026 15:48
Co-authored-by: HackingGate <8541644+HackingGate@users.noreply.github.com>
Co-authored-by: HackingGate <8541644+HackingGate@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 13, 2026

@copilot
Enable manual trigger of CI, and OS selection if possible.

Added manual workflow trigger with OS selection in commit e4235df.

The workflow now supports workflow_dispatch with two inputs:

  1. Operating System(s) to test on: Dropdown to select all, ubuntu-latest, macos-latest, or windows-latest
  2. Typst version to test: Optional text field to specify a version (defaults to all versions if empty)

To use: Navigate to Actions → "Test Typst Out Action" → Click "Run workflow" → Select your options → Run workflow

Copilot AI changed the title Replace deprecated font-noto-sans-cjk with language-specific fonts on macOS Replace deprecated font-noto-sans-cjk on macOS and add manual workflow trigger Jan 13, 2026
@HackingGate HackingGate marked this pull request as ready for review January 13, 2026 16:01
Copilot AI review requested due to automatic review settings January 13, 2026 16:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses a deprecation warning for the font-noto-sans-cjk Homebrew cask by replacing it with individual language-specific font packages, and adds manual workflow triggering capabilities for flexible CI testing.

Changes:

  • Replaced deprecated font-noto-sans-cjk cask with three language-specific casks: font-noto-sans-cjk-tc, font-noto-sans-cjk-jp, and font-noto-sans-cjk-kr
  • Added workflow_dispatch trigger with inputs for OS selection and Typst version specification
  • Implemented logic in detect-changes job to handle manual workflow dispatch with appropriate matrix configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HackingGate HackingGate merged commit 062b8d6 into main Jan 13, 2026
9 checks passed
@HackingGate HackingGate deleted the copilot/fix-font-deprecation-macos branch January 13, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font deprecation on macOS runner

3 participants