Fix float overflow in wall collision detection#928
Merged
gheskett merged 1 commit intoHackerN64:develop/2.4.0from Mar 28, 2026
Merged
Fix float overflow in wall collision detection#928gheskett merged 1 commit intoHackerN64:develop/2.4.0from
gheskett merged 1 commit intoHackerN64:develop/2.4.0from
Conversation
invDenom can values can get very large, its upper limits are bounded by (LEVEL_BOUNDARY_MAX ^ 4) inverse of which could hover around 1E-16. In my hack invDenom ended up being zero causing invisble walls bounded by XZ coordinates. This patch removes necessity to do inverse by multiplying conditions in 'check_wall_vw'.
gheskett
approved these changes
Jan 24, 2026
gheskett
added
vanilla
github-project-automation
Bot
moved this from Needs Review
to Done
in 2.4 (Minor Feature Update)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invDenom can values can get very large, its upper limits are bounded by (LEVEL_BOUNDARY_MAX ^ 4) inverse of which could hover around 1E-16.
In my hack invDenom ended up being zero causing invisble walls bounded by XZ coordinates (maybe -ffast-math moment?). This patch removes necessity to do inverse by multiplying conditions in 'check_wall_vw'.