Skip to content

pages_per_client assert #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-ostapenko merged 6 commits into from
Sep 2, 2025
Merged

pages_per_client assert #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf893f9
fix month
max-ostapenko Aug 20, 2025
cdad0da
fix column order
max-ostapenko Aug 20, 2025
36607a5
pages_per_client assert
max-ostapenko Aug 20, 2025
b59c4ed
Merge branch 'main' into main
max-ostapenko Aug 26, 2025
2a7c8b4
Merge branch 'main' into main
max-ostapenko Sep 2, 2025
cdd955f
Merge branch 'main' into prod
max-ostapenko Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions definitions/output/crawl/pages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,20 @@ ORDER BY cnt_pages DESC
HAVING cnt_pages > 200
`)

assert('pages_per_client')
.tags(['crawl_complete'])
.query(ctx => `
SELECT
client,
COUNT(DISTINCT page) AS cnt_pages
FROM ${ctx.ref('crawl_staging', 'pages')}
WHERE
date = '${constants.currentMonth}'
GROUP BY
client
HAVING cnt_pages < 20000000
`)

publish('pages', {
type: 'incremental',
protected: true,
Expand Down
10 changes: 4 additions & 6 deletions definitions/output/reports/reports_html_elements_popularity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
const pastMonth = constants.fnPastMonth(constants.currentMonth)

publish('html_elements_popularity', {
schema: 'reports',
type: 'incremental',
Expand All @@ -18,7 +16,7 @@ try {
''';

DELETE FROM ${ctx.self()}
WHERE date = '${pastMonth}';
WHERE date = '${constants.currentMonth}';
`).query(ctx => `
WITH pages_data AS (
SELECT
Expand All @@ -29,7 +27,7 @@ WITH pages_data AS (
custom_metrics.element_count
FROM ${ctx.ref('crawl', 'pages')}
WHERE
date = '${pastMonth}' ${constants.devRankFilter}
date = '${constants.currentMonth}' ${constants.devRankFilter}
),

totals AS (
Expand Down Expand Up @@ -69,9 +67,9 @@ SELECT
"destination": "cloud_storage",
"config": {
"bucket": "${constants.bucket}",
"name": "${constants.storagePath}${pastMonth.replaceAll('-', '_')}/htmlElementPopularity.json"
"name": "${constants.storagePath}${constants.currentMonth.replaceAll('-', '_')}/htmlElementPopularity.json"
},
"query": "SELECT * EXCEPT(date) FROM ${ctx.self()} WHERE date = '${pastMonth}'"
"query": "SELECT * EXCEPT(date) FROM ${ctx.self()} WHERE date = '${constants.currentMonth}'"
}'''
);
`)