Skip to content

Read optional ls1 config filename#119

Open
rubenhorn wants to merge 1 commit intomasterfrom
95-make-ls1-config-name-passable-through-couettexml
Open

Read optional ls1 config filename#119
rubenhorn wants to merge 1 commit intomasterfrom
95-make-ls1-config-name-passable-through-couettexml

Conversation

@rubenhorn
Copy link
Copy Markdown
Contributor

@rubenhorn rubenhorn commented Jan 13, 2026

Resolves #95:

<microscopic-solver
   type="ls1"
   ls1config="some_arbitrary_filename.xml"
   temperature="1.1"
   equilibration-steps="0"
   number-md-simulations="1"
   density="0.813037037"
/>

@rubenhorn rubenhorn requested a review from amartyads January 13, 2026 10:01
@rubenhorn rubenhorn linked an issue Jan 13, 2026 that may be closed by this pull request
Make ls1 config name passable through couette.xml #95
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 13, 2026

You should write tests for:
Filename Line Coverage Functions
coupling/configurations/CouetteConfiguration.h 45.00% 100.00%

amartyads
amartyads approved these changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@amartyads amartyads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also planned to have unique XML configs for each unique multiMD sim (see last point in "Planned Features" in the wiki) so this is a good first step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amartyads amartyads amartyads approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make ls1 config name passable through couette.xml

2 participants

@rubenhorn @amartyads