feat(h2): use a more reasonable timer for keep alive timeout in h2#1191
Open
feat(h2): use a more reasonable timer for keep alive timeout in h2#1191
Conversation
9cd7a6a to
0168e11
Compare
0168e11 to
dab8ed7
Compare
Collaborator
|
There is some behavior change in xitca-http 0.9.0 where the ping-pong is running in a fixed interval instead of only when idle. I would suggest using a higher value as default if the default 5 seconds is too harsh. I would push a fix later to resort the behavior to prior 0.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at why the keep alive h2 test was running for so long (5 sec)
and this was the
* 10mult on duration that was causing this.I'm not sure this a good default, and maybe it should be configurable, in fact in h2, it may need 2 different duration configurable: