This repository was archived by the owner on Mar 10, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add strategy edit flow, notification center, and UI polish #17
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
24 changes: 24 additions & 0 deletions
24
manager/migration/005_add_schedule_strategy_update_permission.down.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| [ | ||
| { | ||
| "update": "roles", | ||
| "updates": [ | ||
| { | ||
| "q": { "name": "admin" }, | ||
| "u": { | ||
| "$pull": { | ||
| "policies": { "permissionKey": "schedule_strategy.update" } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "delete": "permissions", | ||
| "deletes": [ | ||
| { | ||
| "q": { "key": "schedule_strategy.update" }, | ||
| "limit": 1 | ||
| } | ||
| ] | ||
| } | ||
| ] |
26 changes: 26 additions & 0 deletions
26
manager/migration/005_add_schedule_strategy_update_permission.up.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| [ | ||
| { | ||
| "insert": "permissions", | ||
| "documents": [ | ||
| { | ||
| "key": "schedule_strategy.update", | ||
| "resource": "schedule_strategy", | ||
| "action": "update", | ||
| "description": "Update schedule strategies" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "update": "roles", | ||
| "updates": [ | ||
| { | ||
| "q": { "name": "admin" }, | ||
| "u": { | ||
| "$push": { | ||
| "policies": { "permissionKey": "schedule_strategy.update", "self": false } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UpdateStrategy repository method doesn't validate that the update was successful. Unlike UpdateUser in repo_rbac.go which checks
res.MatchedCount == 0and returnsdomain.ErrNotFound, this method doesn't verify whether any document was actually modified. This could silently fail if the strategyID doesn't exist in the database (though the service layer does pre-validate).