added feature to snap at midpoint while using path tool#3766
Open
krVatsal wants to merge 2 commits intoGraphiteEditor:masterfrom
Open
added feature to snap at midpoint while using path tool#3766krVatsal wants to merge 2 commits intoGraphiteEditor:masterfrom
krVatsal wants to merge 2 commits intoGraphiteEditor:masterfrom
Conversation
Contributor
Author
|
One small question, does the axes are meant to be at drag point or at the midpoint? |
Contributor
|
Midpoint of the segment. |
Member
|
!build |
|
Member
|
This is behaving correctly except for the fact that we want the X and Y snapping lines to be centered through the initial position of the midpoint of the Bezier segment being molded, rather than the point at which the pointer began dragging the molded segment. |
Contributor
Author
|
Yepp, was working on that part only. Almost done with the work I will push the new commit with that change. |
Keavon
force-pushed
the
shift-key-snaps-lines-from-middle-for-shpes
branch
from
d2413a4 to
183ab31
Compare
Member
|
!build (Run ID 22294708633) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3760
Now when we use path tool to snap any shape(while holding shift) then it snaps from midpoint irrespective of wherever we drag from.