Migrate rich-text package to TypeScript#12233
Merged
swissspidy merged 40 commits intomainfrom Sep 14, 2022
Merged
Conversation
miina
added
Type: Code Quality
miina
commented
Sep 6, 2022
| type: string, | ||
| props: Record<string, unknown>, | ||
| asBackground?: boolean | ||
| ) => Record<string, unknown>, |
Contributor
Author
There was a problem hiding this comment.
Not sure if it makes sense to create a local type Element or add a todo and leave it as is until the elements library package to get converted 🤔
Contributor
Author
There was a problem hiding this comment.
Edit: probably makes sense to wait for #12090
miina
commented
Sep 7, 2022
miina
commented
Sep 8, 2022
Contributor
Author
|
@barklund There are still 2 type errors in |
miina
commented
Sep 9, 2022
Collaborator
|
Plugin builds for b4fc5e2 are ready 🛎️!
|
Contributor
|
Size Change: +17.2 kB (+1%) Total Size: 2.7 MB
ℹ️ View Unchanged
|
barklund
reviewed
Sep 9, 2022
Contributor
barklund
left a comment
barklund
left a comment
There was a problem hiding this comment.
Various comments and suggestions for optimization. Most importantly I feel is typing the generic formatter, so they all conform to a common interface.
Installed with `—force`
barklund
approved these changes
Sep 14, 2022
Contributor
barklund
left a comment
barklund
left a comment
There was a problem hiding this comment.
Looks good to me. It's not perfect, but we're still learning, and the suboptimal bits are only internal to this package, so they shouldn't leak through to the rest of the app anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
as Statecasting right now. Looks like it generally needs some changes to allow selecting the whole state without a selector as well.renderMapdoesn't have the correct type, for matching the type, we'd need to change the logic to useImmutable.Map, however, it works currently as well so I'm wondering ifdraft-jstypes are not complete.User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12179