chore(upgrade golang): Upgrade golang for CVE fixes.#4505
chore(upgrade golang): Upgrade golang for CVE fixes.#4505meet2mky wants to merge 1 commit intov2.5.3_patch_releasefrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Go language version used throughout the project to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly upgrades the Go version to 1.26.1 to address CVEs. My feedback focuses on improving maintainability. In several shell scripts and Dockerfiles, the Go version is hardcoded. I've suggested using variables (GO_VERSION) in shell scripts and ARG in Dockerfiles to centralize the version number. This will make future upgrades much easier. The changes themselves are correct.
df9c92a to
4d04580
Compare
4d04580 to
b338940
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.5.3_patch_release #4505 +/- ##
=======================================================
Coverage ? 78.89%
=======================================================
Files ? 106
Lines ? 11696
Branches ? 0
=======================================================
Hits ? 9228
Misses ? 1991
Partials ? 477
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Upgrade golang for CVE fixes.
Link to the issue in case of a bug fix.
Testing details
Any backward incompatible change? If so, please explain.