Closed
Conversation
Changes to improve retry logic for kernel reader.
* fix: Upgrade jacobsa/fuse for handling large page sizes This change brings this fix to GCSFuse: jacobsa/fuse@f1ba38d which adds handling for page sizes > 4KiB.
…e) and override local metadata in case of rapid appends (#4409) * do not overwrite latest metadata with stale server response in case of rapid appends * unit tests for appropriate cache eviction * unit test for init bwh if eligible method * explicit negative assertion in unit test : zonal * integration test for open-write-close-reopen * nits * improve comment clartiy * explanatory comment for stat call during bwh initialization * retrict relying on kernel obs in append mode only * remove redundant check for empty err * update test case * update comment about zb overwrites also requiring stat call * nit for comment
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
- Coverage 83.67% 83.29% -0.39%
==========================================
Files 161 163 +2
Lines 19446 19985 +539
==========================================
+ Hits 16272 16647 +375
- Misses 2574 2718 +144
- Partials 600 620 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your PR title follows the format:
Example:
feat(api): add user login endpointAvailable types:
feat: A new featurefix: A bug fixdocs: Documentation only changesstyle: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)refactor: A code change that neither fixes a bug nor adds a featureperf: A code change that improves performancetest: Adding missing tests or correcting existing testsbuild: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)chore: Other changes that don't modify src or test filesrevert: Reverts a previous commitDescription
Link to the issue in case of a bug fix.
Testing details
Any backward incompatible change? If so, please explain.